fix cloud server#658
Draft
TheCommCraft wants to merge 1 commit into
Draft
Conversation
Collaborator
Author
|
When we merge this, we will need to update the documentation. |
faretek1
reviewed
Jun 16, 2026
faretek1
left a comment
faretek1
left a comment
Collaborator
There was a problem hiding this comment.
There is a bunch of code duplication between TWCloudServer and TWSslCloudServer. Would it be worth reducing this? Inheritance/polymorphism could work here however that can tend to confuse where actual implementations are. Do you want me to try running this code to see if it works?
| if self.server.log_var_sets: | ||
| print(self.address[0]+":"+str(self.address[1]), "tried to set a var on non-whitelisted project and was disconnected, project:", data["project_id"], "user:",data["user"]) | ||
| print( | ||
| self.address[0] + ":" + str(self.address[1]), |
Collaborator
There was a problem hiding this comment.
This is just because the old code has it, which is kind of a separate issue
Collaborator
Author
|
I guess it can't hurt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves issue #648
Changes
Added SSL version of cloud server and refactored cloud server module
Tests