Skip to content

Conversation

@TimInTech
Copy link
Owner

Pull Request – Simulation Only

Summary

Describe what this PR changes (scripts, docs). No commands are executed in this workspace.

Checklist

  • No commands executed locally; all steps are simulated/explained only.
  • Changes are limited to scripts and/or documentation.
  • SIMULATION.md updated to reflect behavior and risks.
  • If adding a new script or option, included example usage commands (chmod +x; ./script; screen -r ...).
  • Security considerations addressed (least-privilege user, ports, backups).

Testing (Simulation)

Explain expected side effects if run on a proper host (files created, services started, ports opened). Include rollback/cleanup notes.

Resolves #47

- Provides minecraft-bedrock.service for systemd auto-start
- Includes hardening options (NoNewPrivileges, ProtectSystem, etc.)
- Uses screen for console access compatibility
- Automatic restart on failure with 5s delay
Copilot AI review requested due to automatic review settings November 23, 2025 11:17
@TimInTech TimInTech merged commit a163ecc into main Nov 23, 2025
2 checks passed
@TimInTech TimInTech deleted the feature/bedrock-systemd-service branch November 23, 2025 11:19
@chatgpt-codex-connector
Copy link

💡 Codex Review

WorkingDirectory=/opt/minecraft-bedrock
ExecStart=/usr/bin/screen -DmS bedrock /bin/bash -lc './start.sh'
ExecStop=/usr/bin/screen -S bedrock -X quit

P1 Badge Screen start blocked by no-new-privileges

Switching ExecStart to launch the server inside screen will fail on typical hosts because this unit still enforces NoNewPrivileges=true/RestrictSUIDSGID=true later in the file, while distro screen binaries are setuid-root and rely on that privilege to create /run/screen sockets. With the setuid bit suppressed the new screen -DmS bedrock … command exits immediately with a permissions error, so the service cannot start at all when hardened options remain enabled.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants