Skip to content

Conversation

@TimInTech
Copy link
Owner

Summary

  • update the Bedrock systemd unit to declare a forking service when using detached screen
  • add inline comment explaining why forking type is required for screen usage

Testing

  • Not run (not requested)

Codex Task

Copilot AI review requested due to automatic review settings November 23, 2025 10:36
@TimInTech TimInTech merged commit 03356b2 into feature/bedrock-systemd-service Nov 23, 2025
6 checks passed
@TimInTech TimInTech deleted the codex/fix-systemd-service-file-issues branch November 23, 2025 10:37
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Bedrock server systemd service configuration to use Type=forking instead of Type=simple, acknowledging that the screen command detaches from the invoking process. The change includes an inline comment explaining the rationale for using forking type when managing detached screen sessions.

Key Changes:

  • Changed systemd service type from simple to forking to align with screen's detached behavior
  • Added explanatory comments about why forking type is needed for screen session management

TimInTech added a commit that referenced this pull request Nov 23, 2025
* feat: Add Bedrock systemd service file

Resolves #47

- Provides minecraft-bedrock.service for systemd auto-start
- Includes hardening options (NoNewPrivileges, ProtectSystem, etc.)
- Uses screen for console access compatibility
- Automatic restart on failure with 5s delay

* Fix Bedrock service type for detached screen (#63)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants