Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces comprehensive Helm chart support for Kubernetes deployments of the Brimming application. The implementation includes production-ready configurations, database management, and optional components like Firecrawl.
Key changes:
- Complete Helm chart structure with templates for all major components (app, worker, PostgreSQL, Valkey, Firecrawl)
- Comprehensive test coverage using helm-unittest for all templates
- Support for both internal and external database/cache configurations
Reviewed changes
Copilot reviewed 33 out of 34 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| helm/brimming/Chart.yaml | Defines chart metadata and Valkey subchart dependency |
| helm/brimming/values.yaml | Comprehensive configuration options for all components |
| helm/brimming/templates/_helpers.tpl | Template helper functions for resource naming and configuration |
| helm/brimming/templates/deployment-app.yaml | Rails application deployment with health probes and security contexts |
| helm/brimming/templates/deployment-worker.yaml | Sidekiq worker deployment configuration |
| helm/brimming/templates/job-migrate.yaml | Database migration job using Helm hooks |
| helm/brimming/templates/job-seed.yaml | Initial admin user seeding job |
| helm/brimming/templates/postgresql/*.yaml | PostgreSQL StatefulSet, service, and initialization scripts |
| helm/brimming/templates/firecrawl/*.yaml | Firecrawl deployment templates (disabled pending RabbitMQ integration) |
| helm/brimming/tests/*.yaml | Comprehensive helm-unittest test suites |
| docs/phases.md | Updated to mark Phase 18 as complete |
| README.md | Added Helm deployment instructions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.