Skip to content

Fix ConversationsStream.post_process to preserve base class custom_attributes normalization#93

Closed
Copilot wants to merge 3 commits intofernando/fix-missing-tags-in-conversations-streamfrom
copilot/sub-pr-92
Closed

Fix ConversationsStream.post_process to preserve base class custom_attributes normalization#93
Copilot wants to merge 3 commits intofernando/fix-missing-tags-in-conversations-streamfrom
copilot/sub-pr-92

Conversation

Copy link
Copy Markdown

Copilot AI commented Mar 11, 2026

ConversationsStream.post_process overrode IntercomStream.post_process without calling super(), silently bypassing the base class's custom_attributes key normalization (lowercasing, space→underscore).

Changes

  • ConversationsStream.post_process now delegates to super().post_process(row, context) before the aircall tag logging
  • Early-returns None if the base class excludes the record
def post_process(self, row: dict, context: dict | None = None) -> dict | None:
    row = super().post_process(row, context)
    if row is None:
        return None
    aircall_tags = [
        tag for tag in (row.get("tags") or {}).get("tags") or []
        if "aircall" in (tag.get("name") or "").lower()
    ]
    ...
    return row

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…ustom_attributes normalization

Co-authored-by: fcortevargas <47634728+fcortevargas@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix missing tags in Conversations stream Fix ConversationsStream.post_process to preserve base class custom_attributes normalization Mar 11, 2026
@fcortevargas fcortevargas force-pushed the fernando/fix-missing-tags-in-conversations-stream branch from 1efb18e to 3154d42 Compare March 11, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants