[pull] main from awslabs:main#252
Merged
Merged
Conversation
#1583) * fix(fetch): reject connection failures with TypeError: Failed to fetch Network/connection failures threw "Fetch failed. <hyper error>". The AWS SDK retry classifier (@smithy/service-error-classification) only treats a TypeError as a retryable transient error when error.message is exactly "Failed to fetch" (isBrowserNetworkError), so SNS (and other SDK) calls were classified as CLIENT_ERROR and not retried (attempts: 1), ignoring the configured retry policy. Throw exactly TypeError: Failed to fetch on connection failure, matching the WHATWG Fetch spec and the SDK's transient-error allow-list, and attach the underlying hyper error as error.cause to preserve diagnostics. Fixes #1482 * fmt --------- Co-authored-by: richarddd <richard.davison1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )