Conversation
- Automatically promote mixin or config :defines and :flags lists to `*` matchers if mixin and config conventions do not match. - Enabled `:extend_existing_arrays` for `deep_merge()` to handle config / mixin merge cases of a value as a single string merged with an array of strings. - Added merge warnings to log any oddball edge cases where a mixin value would silently clobber a config value
- Spoke to the design intent and recommendation to think in terms of additive merges - Clarified merge rules - Limited reorganization of headings
Letme
reviewed
Mar 11, 2025
Contributor
Letme
left a comment
Letme
left a comment
There was a problem hiding this comment.
Great feature. It would help with the migration from 0.31 version to 1.0 version. So LGTM.
|
|
||
| Ceedling provides reasonably verbose logging at startup telling you which | ||
| configuration files were used and in what order they were merged. | ||
| configuration file and Mixins were used and in what order they were merged. |
Contributor
There was a problem hiding this comment.
Suggested change
| configuration file and Mixins were used and in what order they were merged. | |
| configuration file and Mixins were used, and in what order they were merged. |
Member
Author
There was a problem hiding this comment.
A comma here would not be correct grammar. A comma is only needed in a list of 3 or more items, for clarity / a pause, or to join two independent clauses (noun + verb sentences). None of these conditions are met.
Co-authored-by: Crt Mori <cmo@melexis.com>
`nullptr` is a recognized keyword in C23 and later. Use a name that does not collide while retaining the intended bad pointer dereferencing.
`bool` is a recognized keyword in C23 and later. Use `#include <stdbool.h>` as a version agnostic solution for use of `bool` as a type. This approach is backwards compatible to C99.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
:definesor:flagsconfig or mixin conventions mismatch (array vs. matcher hash), the array is promoted to the hash-style*matcher automatically with a notice logging this modification.deep_merge()to handle the case of merging mixin single values into config arrays (typically a single string into an array of strings).