Skip to content

frontend: templates: components: search-summary-box: remove elements#1228

Merged
BibianaC merged 2 commits intolivefrom
bc/remove-elements-from-search-summary
Jan 27, 2026
Merged

frontend: templates: components: search-summary-box: remove elements#1228
BibianaC merged 2 commits intolivefrom
bc/remove-elements-from-search-summary

Conversation

@BibianaC
Copy link
Copy Markdown
Member

#1197

I have moved "Total non-GBP grants" from "highlighted grants" to the "Search summary" as it is the only data. I can move it back.

Screenshot 2026-01-14 at 12 25 17 Screenshot 2026-01-14 at 12 31 52

@coveralls
Copy link
Copy Markdown

coveralls commented Jan 14, 2026

Pull Request Test Coverage Report for Build 20994435060

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 55 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-2.8%) to 71.234%

Files with Coverage Reduction New Missed Lines %
grantnav/frontend/templatetags/frontend.py 12 81.71%
grantnav/frontend/templatetags/graphs.py 43 20.34%
Totals Coverage Status
Change from base Build 19134242218: -2.8%
Covered Lines: 1409
Relevant Lines: 1978

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@mariongalley mariongalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve on the basis of the screenshots

@BibianaC
Copy link
Copy Markdown
Member Author

Thanks @mariongalley.

@R2ZER0 @mrshll1001, if it is okay with you, I will merge this PR.

@BibianaC BibianaC requested a review from mrshll1001 January 23, 2026 12:47
Copy link
Copy Markdown

@mrshll1001 mrshll1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to approve this on the basis of the screenshots and the code reflecting what I'd expect of this change.

You're clear to merge :-)

@BibianaC BibianaC merged commit e23a7ec into live Jan 27, 2026
6 checks passed
@BibianaC BibianaC deleted the bc/remove-elements-from-search-summary branch January 27, 2026 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants