This repository was archived by the owner on Mar 22, 2023. It is now read-only.
Properly merge custom and default renderers#12
Open
Exilz wants to merge 1 commit intoThomas101:masterfrom
Open
Properly merge custom and default renderers#12Exilz wants to merge 1 commit intoThomas101:masterfrom
Exilz wants to merge 1 commit intoThomas101:masterfrom
Conversation
|
+1 please merge, this solution works |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a problem with the custom renderers prop.
If you provide some custom renderers, (ie : only for
<h2>), the default one will not be merged with your custom ones.Before I realized it,
<img>weren't showing anymore on my app.I merged
HTMLRenderersand the optionnalrenderersprop in the constructor so I could use it on line 90.I left untouched
defaultProps.