Open
Conversation
…ved every reference to NoneType with type(None), changed urllib2 import to urllib.error, basestring isn't Python 3 compatible so changed every reference to it to str, and iteritems() was changed to items() b/c that also isn't Python 3 compatible
… to type(None) and every reference to iteritems() changed to items() b/c iteritems() isn't Python 3 compatible
Author
|
bump |
Browser class is currently hard coded to use the selenium chrome local plugin. Most of the logic has been removed to a Mixin class to be used re-used with the selenium remote browser plugin. Also bunch of pep8 stuff.
Also some PEP8 changes.
Remote selenium
add RemoteBrowser parameters to varialbes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated ngSe to be Python 3 compatible.
How to Verify
Run selenium and/or ngSe in Python 3 and see if all actions still run correctly.
Side Effects
I've heard there are slight differences between Python 2.x iteritems() and Python 3.x items(), but to be honest I had trouble figuring out if there was a better option than items().
fixes #8