[11.0][ADD] auditlog_security by thomaspaulb · Pull Request #1 · Therp/server-tools

thomaspaulb · 2022-06-02T10:52:54Z

No description provided.

auditlog_security/views/auditlog_view.xml

gfcapalbo · 2022-06-07T13:17:28Z

@thomaspaulb linted XML and added many2many_tags widget to the fields in treeview.
I think that covers it all.

auditlog_security/models/auditlog_line_access_rule.py

auditlog_security/views/auditlog_view.xml

thomaspaulb · 2022-07-19T11:39:57Z

@KKamaa TODO here:

All users can now see "View Logs" and "View Log Lines", whereas most users should just see "View Log Lines" ---> I propose to create a new security group "View Auditlog logs" that people can have, which allows them to see the "View Logs" button, and we just disable that for most (if not all) people.
I see that the auditlog security rules have a "name" field, but it's not editable on the form view and I don't think it makes sense so we could remove it.

auditlog_security/models/auditlog_rule.py

auditlog_security/views/auditlog_view.xml

auditlog_security/models/auditlog_rule.py

thomaspaulb · 2022-07-25T09:27:37Z

auditlog_security/models/auditlog_line_access_rule.py

+        # return with context key so that deletion will not be forbidden
+        return self.env["ir.rule"].search(
+            [("auditlog_line_access_rule_id", "in", self.ids)]
+        )


TBH why is this a function, we could just make it into a One2many field definition of ir_rule_ids ?

I like this more, this is the access for 1 rule the function is readable. leaving pending.

auditlog_security/models/auditlog_line_access_rule.py

auditlog_security/models/auditlog_log_line.py

auditlog_security/models/auditlog_rule.py

auditlog_security/models/auditlog_line_access_rule.py

auditlog_security/models/auditlog_rule.py

auditlog_security/models/auditlog_line_access_rule.py

auditlog_security/models/auditlog_rule.py

…anup too.

auditlog_security/models/auditlog_rule.py

…s are unlinked When a field or a model is unlinked, keep the related audit logs. Denormalize the field and model info on the logs and log lines so that the information is still available after the deletion of the related data model. Also, to improve the performance of the deletion of fields and models, add indexes on the log's model_id and log line's field_id. Co-Authored-By: Stefan Rijnhart <stefan@opener.am>

…r fields are unlinked

auditlog_security/models/auditlog_rule.py

auditlog_security/models/auditlog_log_line.py

gfcapalbo · 2022-07-28T14:37:09Z

@thomaspaulb I have implemented what we discussed.
I cannot be sure if there are some "perfoemance degradation bombs" I have not thought about, but i have verified that the ormcache clear is trigger when we change auditlog_line_access_rule_ids.

of logged fields

…e number of logged fields

…o reduce number of logged fields

…thods to reduce number of logged fields

… and methods to reduce number of logged fields

…ssions, and methods to reduce number of logged fields

gfcapalbo added 2 commits April 13, 2022 17:17

[ADD] pre-review version

fe00f4c

[ADD] review fixes

aded99e

thomaspaulb mentioned this pull request Jun 2, 2022

11.0 auditlog extension sunflowerit/server-tools#4

Closed

fixup! [ADD] review fixes

386127b

thomaspaulb commented Jun 2, 2022

View reviewed changes

gfcapalbo added 2 commits June 7, 2022 11:59

[ADD] Lint XML

98f670a

[ADD] show nicer group_ids and field_ids in treeview

b332384

[FIX] open issues and errors

de40a70

KKamaa reviewed Jul 5, 2022

View reviewed changes

auditlog_security/models/auditlog_line_access_rule.py Outdated Show resolved Hide resolved

KKamaa reviewed Jul 5, 2022

View reviewed changes

auditlog_security/views/auditlog_view.xml Outdated Show resolved Hide resolved

KKamaa reviewed Jul 5, 2022

View reviewed changes

auditlog_security/views/auditlog_view.xml Outdated Show resolved Hide resolved

fixup! [FIX] open issues and errors

1896427

thomaspaulb commented Jul 19, 2022

View reviewed changes

auditlog_security/models/auditlog_rule.py Outdated Show resolved Hide resolved

thomaspaulb commented Jul 19, 2022

View reviewed changes

auditlog_security/models/auditlog_rule.py Outdated Show resolved Hide resolved

thomaspaulb commented Jul 19, 2022

View reviewed changes

auditlog_security/models/auditlog_rule.py Outdated Show resolved Hide resolved

gfcapalbo force-pushed the 11.0-auditlog_extension branch from eab1c5f to 57cb6b0 Compare July 20, 2022 16:50

[FIX] fixes points 1,3,4,7

42a3b7e

gfcapalbo force-pushed the 11.0-auditlog_extension branch from 57cb6b0 to 42a3b7e Compare July 20, 2022 16:56

[FIX] point 2: server actions instead of window action

4173a72

thomaspaulb commented Jul 21, 2022

View reviewed changes

auditlog_security/models/auditlog_rule.py Outdated Show resolved Hide resolved

thomaspaulb commented Jul 21, 2022

View reviewed changes

auditlog_security/models/auditlog_rule.py Show resolved Hide resolved

fixup! [FIX] point 2: server actions instead of window action

db95a56

thomaspaulb commented Jul 21, 2022

View reviewed changes

auditlog_security/models/auditlog_rule.py Outdated Show resolved Hide resolved

auditlog_security/models/auditlog_rule.py Outdated Show resolved Hide resolved

auditlog_security/views/auditlog_view.xml Outdated Show resolved Hide resolved

thomaspaulb commented Jul 25, 2022

View reviewed changes

auditlog_security/models/auditlog_line_access_rule.py Outdated Show resolved Hide resolved

auditlog_security/models/auditlog_rule.py Show resolved Hide resolved

thomaspaulb commented Jul 25, 2022

View reviewed changes

auditlog_security/models/auditlog_line_access_rule.py Outdated Show resolved Hide resolved

thomaspaulb commented Jul 25, 2022

View reviewed changes

auditlog_security/models/auditlog_rule.py Outdated Show resolved Hide resolved

gfcapalbo added 2 commits July 26, 2022 11:14

[FIX] user_id fix, use related fields , allows for massive cleanup too.

7eff32c

fixup! [FIX] user_id fix, use related fields , allows for massive cle…

9bcce33

…anup too.

thomaspaulb commented Jul 26, 2022

View reviewed changes

auditlog_security/models/auditlog_rule.py Outdated Show resolved Hide resolved

Pieter Paulussen and others added 2 commits July 26, 2022 13:33

fixup! [IMP] auditlog: prevent cascading delete of logs when models o…

568c754

…r fields are unlinked

gfcapalbo force-pushed the 11.0-auditlog_extension branch from d968cf6 to 92b0afb Compare July 26, 2022 12:47

[IMP] review improvements

c3fb342

gfcapalbo force-pushed the 11.0-auditlog_extension branch from c533770 to c3fb342 Compare July 26, 2022 16:06

fixup! [IMP] review improvements

eb494a8

thomaspaulb commented Jul 27, 2022

View reviewed changes

auditlog_security/models/auditlog_rule.py Outdated Show resolved Hide resolved

thomaspaulb commented Jul 27, 2022

View reviewed changes

auditlog_security/models/auditlog_log_line.py Show resolved Hide resolved

gfcapalbo added 8 commits July 27, 2022 10:44

[FIX] second review

6dbb364

fixup! [FIX] second review

f8bd300

fixup! [FIX] second review

385407e

fixup! [FIX] second review

b55f32d

fixup! [FIX] second review

80426f0

[ADD] standard log view now restricted, only loglines for normal users

4c04c1b

fixup! fixup! [FIX] second review

999aff1

[IMP] Add filtering and correct problems with display

ff6b23f

gfcapalbo force-pushed the 11.0-auditlog_extension branch from e447224 to d031f6a Compare July 28, 2022 14:29

[IMP] no more access errors, regressions, and methods to reduce number

b09f5b8

of logged fields

gfcapalbo force-pushed the 11.0-auditlog_extension branch from 4885b60 to b09f5b8 Compare July 28, 2022 16:53

Tom Blauwendraat and others added 5 commits August 19, 2022 13:54

fixup! [IMP] no more access errors, regressions, and methods to reduc…

5cac37f

…e number of logged fields

fixup! fixup! [IMP] no more access errors, regressions, and methods t…

d9c99f2

…o reduce number of logged fields

fixup! fixup! fixup! [IMP] no more access errors, regressions, and me…

f08ee94

…thods to reduce number of logged fields

fixup! fixup! fixup! fixup! [IMP] no more access errors, regressions,…

e1c4f7c

… and methods to reduce number of logged fields

fixup! fixup! fixup! fixup! fixup! [IMP] no more access errors, regre…

6b71963

…ssions, and methods to reduce number of logged fields

Conversation

thomaspaulb commented Jun 2, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gfcapalbo commented Jun 7, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thomaspaulb commented Jul 19, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thomaspaulb Jul 25, 2022

Choose a reason for hiding this comment

Uh oh!

gfcapalbo Jul 26, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gfcapalbo commented Jul 28, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants