limit number of galaxies to 1000, configured in gal_catalog_config.ini#10
Open
moira-andrews wants to merge 2 commits intomasterfrom
Open
limit number of galaxies to 1000, configured in gal_catalog_config.ini#10moira-andrews wants to merge 2 commits intomasterfrom
moira-andrews wants to merge 2 commits intomasterfrom
Conversation
swyatt7
requested changes
Nov 17, 2025
Collaborator
swyatt7
left a comment
swyatt7
left a comment
There was a problem hiding this comment.
Just some small variable name changes then should be good to go.
Comment on lines
+181
to
+184
| if len(ii) > ngalaxtoshow: | ||
| n = ngalaxtoshow | ||
| else: | ||
| n = len(ii) |
Collaborator
There was a problem hiding this comment.
Let's name n something more meaningful.
Also can you name ii something more meaningful as well?
Contributor
Author
There was a problem hiding this comment.
Alright, updated in most recent commit!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helps with large localization regions so the database doesn't ingest all the galaxies and cause page loading issues. Can be reduced further.