refactor: use RETAIL_COMPATIBLE_XFER_SAVE flag and change glueEnforcer to void

Author: bobtista

Core/Libraries/Source/WWVegas/WWLib/always.h

@@ -144,7 +144,7 @@ private: \
 		return The##ARGCLASS##Pool; \
 	} \
 protected: \
-	virtual int glueEnforcer() const { return sizeof(*this); } \
+	virtual void glueEnforcer() const { } \
 public: \
 	inline void* operator new(size_t s) { return allocateFromW3DMemPool(getClassMemoryPool(), s); } \
 	inline void operator delete(void *p) { freeFromW3DMemPool(getClassMemoryPool(), p); } \
@@ -162,7 +162,7 @@ class W3DMPO
 	}
 protected:
 	// we never call this; it is present to cause compile errors in descendent classes
-	virtual int glueEnforcer() const = 0;
+	virtual void glueEnforcer() const = 0;
 public:
 	virtual ~W3DMPO() { /* nothing */ }
 };

Generals/Code/GameEngine/Include/Common/BitFlagsIO.h

@@ -214,12 +214,10 @@ void BitFlags<NUMBITS>::xfer(Xfer* xfer)
 	{
 
 		// just call the xfer implementation on the data values
-		// TheSuperHackers @bugfix bobtista 05/12/2025 Fix sizeof(this) bug
-		// Original code used sizeof(this) which is pointer size
-#ifndef RETAIL_COMPATIBLE_CRC
-		xfer->xferUser( this, sizeof( *this ) );
-#else
+#if RETAIL_COMPATIBLE_XFER_SAVE
 		xfer->xferUser( this, sizeof( this ) );
+#else
+		xfer->xferUser( this, sizeof( *this ) );
 #endif
 
 	}

GeneralsMD/Code/GameEngine/Include/Common/BitFlagsIO.h

@@ -214,12 +214,10 @@ void BitFlags<NUMBITS>::xfer(Xfer* xfer)
 	{
 
 		// just call the xfer implementation on the data values
-		// TheSuperHackers @bugfix bobtista 05/12/2025 Fix sizeof(this) bug
-		// Original code used sizeof(this) which is pointer size
-#ifndef RETAIL_COMPATIBLE_CRC
-		xfer->xferUser( this, sizeof( *this ) );
-#else
+#if RETAIL_COMPATIBLE_XFER_SAVE
 		xfer->xferUser( this, sizeof( this ) );
+#else
+		xfer->xferUser( this, sizeof( *this ) );
 #endif
 
 	}