compat: add RETAIL_COMPATIBLE_CRC flag for BitFlags sizeof fix

bobtista · bobtista · commit 04ebb42fd4a4 · 2025-12-05T13:22:37.000-05:00
diff --git a/Generals/Code/GameEngine/Include/Common/BitFlagsIO.h b/Generals/Code/GameEngine/Include/Common/BitFlagsIO.h
@@ -214,7 +214,13 @@ void BitFlags<NUMBITS>::xfer(Xfer* xfer)
 	{
 
 		// just call the xfer implementation on the data values
+		// TheSuperHackers @bugfix bobtista 05/12/2025 Fix sizeof(this) bug
+		// Original code used sizeof(this) which is pointer size
+#ifndef RETAIL_COMPATIBLE_CRC
 		xfer->xferUser( this, sizeof( *this ) );
+#else
+		xfer->xferUser( this, sizeof( this ) );
+#endif
 
 	}
 	else
diff --git a/GeneralsMD/Code/GameEngine/Include/Common/BitFlagsIO.h b/GeneralsMD/Code/GameEngine/Include/Common/BitFlagsIO.h
@@ -214,7 +214,13 @@ void BitFlags<NUMBITS>::xfer(Xfer* xfer)
 	{
 
 		// just call the xfer implementation on the data values
+		// TheSuperHackers @bugfix bobtista 05/12/2025 Fix sizeof(this) bug
+		// Original code used sizeof(this) which is pointer size
+#ifndef RETAIL_COMPATIBLE_CRC
 		xfer->xferUser( this, sizeof( *this ) );
+#else
+		xfer->xferUser( this, sizeof( this ) );
+#endif
 
 	}
 	else

Original file line number	Diff line number	Diff line change
`@@ -214,7 +214,13 @@ void BitFlags<NUMBITS>::xfer(Xfer* xfer)`
`214`	`214`	`{`
`215`	`215`
`216`	`216`	`// just call the xfer implementation on the data values`
	`217`	`+ // TheSuperHackers @bugfix bobtista 05/12/2025 Fix sizeof(this) bug`
	`218`	`+ // Original code used sizeof(this) which is pointer size`
	`219`	`+#ifndef RETAIL_COMPATIBLE_CRC`
`217`	`220`	`xfer->xferUser( this, sizeof( *this ) );`
	`221`	`+#else`
	`222`	`+ xfer->xferUser( this, sizeof( this ) );`
	`223`	`+#endif`
`218`	`224`
`219`	`225`	`}`
`220`	`226`	`else`