Fix failing build when building against Java 11 LTS.#2
Open
amugofjava wants to merge 1 commit intoTheSMSWorks:masterfrom
Open
Fix failing build when building against Java 11 LTS.#2amugofjava wants to merge 1 commit intoTheSMSWorks:masterfrom
amugofjava wants to merge 1 commit intoTheSMSWorks:masterfrom
Conversation
… to Java 11 whilst adding comments section to allow building against Java 8 if still required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing pom.xml was failing when building against Java 11 (which is the current LTS version). The pom file has been migrated to Java 11, whilst retaining the necessary Java 8 options in a comments block so that it is still possible to build against Java 8.