Skip to content

Update ProfileScreen data bindings #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheRealAshik merged 1 commit into from
May 16, 2026
Merged

Update ProfileScreen data bindings #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions composeApp/src/commonMain/kotlin/dev/therealashik/github/profile/ProfileScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,6 +393,26 @@ private fun NavigationListSection(
count = state.starredCount,
onClick = { /* TODO */ }
)
NavigationItem(
icon = {
Box(
modifier = Modifier
.size(Dimens.IconSizeLarge)
.clip(MaterialTheme.shapes.small)
.background(MaterialTheme.colorScheme.primaryContainer),
contentAlignment = Alignment.Center
) {
Icon(
imageVector = Icons.Outlined.ViewTimeline,
contentDescription = null,
tint = MaterialTheme.colorScheme.onPrimaryContainer
)
}
},
label = stringResource(Res.string.nav_projects),
count = 0,
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The count for the Projects item is hardcoded to 0. This contradicts the pull request's objective of ensuring ProfileUiState variables properly propagate and handling UI elements dynamically via State. To maintain consistency with other navigation items (such as Starred), this value should be sourced from the state. Please add a projectsCount field to ProfileUiState.Success and update the ProfileViewModel to provide the actual count.

onClick = { /* TODO */ }
)
}
}

Expand Down
Loading