Draft
Conversation
Dramelac
requested changes
Feb 23, 2023
| if not self.__enable_sound: | ||
| logger.verbose("Config: Enabling sound sharing") | ||
| try: | ||
| self.addVolume(SoundUtils.getPulseAudioSocketPath(), "/run/user/0/pulse/native", must_exist=False) |
Member
There was a problem hiding this comment.
Why must_exist is set to False here ? Shouldn't be True instead ?
If the socket is not present, the feature cannot be activated.
Member
There was a problem hiding this comment.
Just below, he left a commented FIXME, indicating that a solution must be found here. In it's current state and in this context, the addVolume function raises an error when must_exist is True 😉
Member
ShutdownRepo
left a comment
ShutdownRepo
left a comment
There was a problem hiding this comment.
@TahiTi forgot to edit this PR to a draft, doing it now
| if not self.__enable_sound: | ||
| logger.verbose("Config: Enabling sound sharing") | ||
| try: | ||
| self.addVolume(SoundUtils.getPulseAudioSocketPath(), "/run/user/0/pulse/native", must_exist=False) |
Member
There was a problem hiding this comment.
Just below, he left a commented FIXME, indicating that a solution must be found here. In it's current state and in this context, the addVolume function raises an error when must_exist is True 😉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding audio support to containers using PulseAudio server socket.
Point of attention
TODO :