Show or Hide item links after movement#101
Open
Kerothan wants to merge 1 commit intoThePix:masterfrom
Open
Conversation
KVonGit
approved these changes
Dec 7, 2024
Contributor
KVonGit
left a comment
KVonGit
left a comment
There was a problem hiding this comment.
Looks good to me.
I would say include updateItemLinks2, but I don't see it being called anywhere anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed with the original item-links code, items outside of the current view/scope would still be linked and have dropdowns but just return "not here" messages when clicked. This will disable the link on items that are no longer in scope so they display as regular text, and re-enable the link when they are within scope again