docs(auth): add docs/AUTH.md — single source of truth (KLA-410)#21
Merged
Conversation
Lands the auth/authz/MCP-trust-model write-up that the security feedback called out as missing. Covers: - API-key + OAuth client-credentials flows, storage, env precedence - The honest "jc has no internal authz layer" point - CLI confirmation model + 30 destructive MCP tools and the agent-controlled execute=true gate - MCP server transport-by-transport posture (stdio / SSE / Streamable HTTP), tool allow/block lists, --read-only mode, rate limiting - Audit log shape, redaction list, and the operator-identity gap - Threat-model summary table per scenario - Cross-links to KLA-407 (default-flip), KLA-408 (step-up auth), and KLA-409 (allowlist + read-only) for the work that's still pending README links into the new doc from the existing Authentication Methods section. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced Apr 28, 2026
jrennichjc
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes KLA-410.
Adds
docs/AUTH.md— the doc the security feedback called out as missing. It pulls together howjcauthenticates, what it does and does not enforce on its own, how the MCP server's trust model varies by transport, what the audit log captures, and what the threat model looks like per scenario. Links from the existing Authentication Methods section in the README.The doc is honest about gaps that are tracked but not yet shipped:
execute: truegate is agent-controlled with no human-in-the-loop or signed identity (KLA-408)Every code-anchored claim cites a
internal/.../*.go:linelocation so reviewers can verify each statement against the source.Notable corrections vs. the original audit
While verifying facts against the code, two things from the earlier audit summary turned out to be wrong and are stated correctly in the doc:
127.0.0.1by default, not all interfaces. There's an explicit warning when binding non-loopback without TLS (internal/cmd/mcp.go:218).destructiveInputpattern, not 17.Test plan
go build ./...cleango test ./internal/cmd/... ./internal/config/... ./internal/api/... ./internal/mcp/...passingwc -l docs/AUTH.md→ 355 lines (acceptance: ≤600)🤖 Generated with Claude Code
Note
Low Risk
Documentation-only change: adds an auth/authorization and MCP security model reference with no runtime or behavior changes.
Overview
Adds a new
docs/AUTH.mdas a single source of truth forjc’s authentication methods, credential storage/precedence, authorization limitations, destructive-operation gating (CLI confirmation + MCPexecute: true), MCP transport trust model, and MCP audit log shape/redaction.Updates
README.mdto link todocs/AUTH.mdfrom the Authentication Methods section so security reviewers have one canonical reference.Reviewed by Cursor Bugbot for commit 290b8ad. Bugbot is set up for automated code reviews on this repo. Configure here.