TASK: Ensure PEP 8 compliance (#82)#94
TASK: Ensure PEP 8 compliance (#82)#94PFCAaron12 wants to merge 2 commits intoTheGittyPerson:mainfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for opening your first PR on this repository! Make sure you've read our contributing guidelines — it's very important to us.
Key things to remember when contributing to this repo:
- Avoid touching others' code when possible
- Rebase > Merge; When updating your PR branch, always use a rebase and resolve conflicts
- Try to follow PEP 8
- Avoid using AI to code, comments, or issue/PR descriptions
|
Hi! Thanks for the contribution; I will review your changes in a bit. But first, as mentioned in the contributing guidelines, you should avoid using a merge to update your PR branch. Please reset your branch to the commit right before the merge commit, then rebase your branch onto main instead before we proceed. Thanks! |
TheGittyPerson
added
refactor
TheGittyPerson
left a comment
TheGittyPerson
left a comment
There was a problem hiding this comment.
After addressing the above comment:
| profile=Profile(name="Syed Abdul Aman", gender="male"), | ||
| professional=Professional(occupation="Generative AI Developer"), | ||
| profile = Profile(name="Syed Abdul Aman", gender="male"), | ||
| professional = Professional(occupation="Generative AI Developer"), |
There was a problem hiding this comment.
For keyword arguments, the equal sign should not have spaces around it: https://peps.python.org/pep-0008/#other-recommendations
|
I have made the first change which is creating a new branch, added myself to the town, and created a pull request for it. Pull request #95. |
2 participants
[📋 Completed Task Template]
Changes
the_town.py:
-Fixed the spacing on each side of the = operator for the instance variables
-Add an instance of myself
theperson/person.py:
-no changes
theperson/goals:
-Changed 'initialise' to 'initialize' to create consistency with other files that used 'initalize'
-Edited the top docstring by putting the last word on the next line to comply with PEP 8's 72 character per line max when it comes to comments and docstrings
theperson/mood.py
-Changed 'initialise' to 'initialize' to create consistency with other files that used 'initalize'
-Edited the top docstring by putting the last word on the next line to comply with PEP 8's 72 character per line max when it comes to comments and docstrings
Closes #82