Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
TheGittyPerson
changed the title
smile method (#50)
TheGittyPerson
added
feature
|
Will be reviewing in an hour 👍 |
TheGittyPerson
left a comment
TheGittyPerson
left a comment
There was a problem hiding this comment.
Thanks for your PR! Just a few formatting fixes before we move on
| """ | ||
| print("\U0001f44b") # Unicode for waving hand emoji | ||
|
|
||
| def smile(self,smile_type:str = "😊") -> None: |
There was a problem hiding this comment.
Since this is a static method, add @staticmethod before this line (and remove the self argument)
| """ | ||
| print("\U0001f44b") # Unicode for waving hand emoji | ||
|
|
||
| def smile(self,smile_type:str = "😊") -> None: |
There was a problem hiding this comment.
Also add a space after the comma and colon.
| """Prints a smile emoji. | ||
| Args: smile_type:The type of smile to display. | ||
| options: '🙂', '☺️', '😊', '😁', '😄' """ |
There was a problem hiding this comment.
This is a bit weirdly formatted. Consider:
"""Print a smile emoji.
Args:
smile_type: The type of smile to display.
Options: '🙂', '☺️', '😊', '😁', '😄'
"""Notice the docstring should also be in imperative mood instead of descriptive
|
@kavyangaHA Hello! Here's a friendly reminder that it's been 10 days since my review of your PR. If you're having trouble fixing the issues, please let me know |
|
@kavyangaHA I will be closing this PR soon. Please leave a comment tagging me if you're able to work on this task again, or if you're busy and don't want to work on this task anymore anyway 👍 |
|
Please open a new PR when you're back, addressing my review comments. Thanks. |
2 participants
Summarize your changes here.
Closes #50
Changes
Resolves #50