TASK: Add Measurement class (#18)

[Poorna-Chandra-D]

Summary

Adds a Measurement class to represent a numeric measurement with a unit (meters, centimeters, feet, inches), and integrates it into the Person class to replace the bare float height attribute.

Changes

• New file src/measurement.py — adds Measurement class with:
  • value and unit attributes
  • Validation for non-negative values and recognized units (meters, centimeters, feet, inches)
  • __str__ returning a human-readable representation (1.8 meters)
  • __repr__ for developer convenience
• Updated src/person.py:
  • height attribute type changed from float | None to Measurement | None
  • introduce() displays self.height naturally via str(Measurement) output
  • New set_height(value, unit) method for convenient height assignment.

Usage

from person import Person
from measurement import Measurement

p = Person(name="Alice", height=Measurement(1.7, "meters"))
p.set_height(170, "centimeters")
p.introduce()
# I am 170 centimeters tall.

Closes #18

[TheGittyPerson]

@Poorna-Chandra-D Since this is a duplicate of #46 (@P-r-e-m-i-u-m submitted the PR first but you started working first, I thought it would be unfair to choose one), are you interested in working with @P-r-e-m-i-u-m?

It's totally fine if you prefer to work solo (@P-r-e-m-i-u-m has already worked on many PRs so don't feel guilty). If you want to collaborate with him, you may discuss with him in his PR (or tag him here).

[TheGittyPerson]

Updated your branch 👍

[TheGittyPerson]

Thanks for your PR. This is a very well-written module and there are minimal errors. Here are a few improvement suggestions I have for you:

[TheGittyPerson]

@Poorna-Chandra-D are you able to address my review comments? If you're busy or unable to do so, I completely understand 👍

[Poorna-Chandra-D]

Thanks for checking in. I am okay with @P-r-e-m-i-u-m incorporating my Measurement updates and your review suggestions into #46. Since #48 is a duplicate, feel free to proceed with #46 as the main PR.

[Poorna-Chandra-D]

@TheGittyPerson confirming: the commented review points have been addressed in the updated Measurement implementation (VALID_UNITS now includes aliases, comparison behavior is consistent with exact equality/ordering, and total_ordering is used so <=/>=/ > are supported).

[P-r-e-m-i-u-m]

"Incorporated review feedback from #48 — rejected bool in value check, added lt and @total_ordering for full comparison support. Ready for re-review @TheGittyPerson 👍"

[TheGittyPerson]

Here are some more suggestions for improvement. Please do ask if you have any questions

[TheGittyPerson]

Please ignore the above change request comment, it was meant to go to Premium's PR (I got confused because the titles are the same lol)

[github-actions]

This pull request has been inactive for some time, and will therefore be marked as 'stale'.
Tag a maintainer if you wish to discuss this further.