rust client: fix disabled-feature case#9
Open
stephanroslen wants to merge 1 commit intoTheCodingBuddies:mainfrom
Open
rust client: fix disabled-feature case#9stephanroslen wants to merge 1 commit intoTheCodingBuddies:mainfrom
stephanroslen wants to merge 1 commit intoTheCodingBuddies:mainfrom
Conversation
stephanroslen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reproducer: build the library without enabled feature flag
symptom 1: build fails because because of use of
error!fix: added missing cfg before error
symptom 2: warning for unused variables
fix: depending on disabled flag allowed unused variables in according lines