Skip to content

Improve quick_select with type hints, edge case handling, and documentation#14473

Closed
ashlesha-sarma wants to merge 3 commits intoTheAlgorithms:masterfrom
ashlesha-sarma:improve-quick-select
Closed

Improve quick_select with type hints, edge case handling, and documentation#14473
ashlesha-sarma wants to merge 3 commits intoTheAlgorithms:masterfrom
ashlesha-sarma:improve-quick-select

Conversation

@ashlesha-sarma
Copy link
Copy Markdown

Describe your change:

  • Added type hints for improved readability and maintainability
  • Handled edge cases (empty input, invalid index)
  • Improved pivot selection using random.choice
  • Standardized variable naming for consistency
  • Enhanced docstrings with detailed explanations and time complexity
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Mar 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant