fix: allocate sizeof(struct data) in prime factoriziation#1573
Open
SAY-5 wants to merge 1 commit into
Open
Conversation
Inside int_fact, the local 'int *range' shadows the 'range' typedef, so malloc(sizeof(range)) reserves only sizeof(int*) bytes. Writing pstr->length one line later overflows the heap allocation. Reproduces under AddressSanitizer. Allocate sizeof(struct data) instead, which the issue author suggested as a working fix. Closes TheAlgorithms#1568 Signed-off-by: SAY-5 <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
In
math/prime_factoriziation.c::int_fact, the localint *rangeshadows therangetypedef on the line above, somalloc(sizeof(range))reserves onlysizeof(int *)bytes (8 on a 64-bit system) instead ofsizeof(struct data)(16). Writingpstr->length = countlater in the same function overflows the heap allocation.AddressSanitizer reports the issue on the assignment, matching the report in #1568. After replacing the argument with
sizeof(struct data)(one of the two suggested fixes in the issue), ASan runs clean.References
Closes #1568
Checklist
Notes: One-line fix to a heap-buffer-overflow in the prime factoriziation example.