Add generate_keywords and fix correlate_news substring false-positives#44
Merged
Codex-Crusader merged 1 commit intomainfrom Apr 14, 2026
Merged
Conversation
- Add generate_keywords() to src/news.py: auto-builds keyword list for any
ticker from yfinance metadata (name tokens, executive surnames). Uses a
daemon thread with REQUEST_TIMEOUT to avoid hanging on network failures.
- Fix correlate_news() in src/signals.py: replace plain substring matching
(kw in blob) with word-boundary regex (_kw_re). Prevents short keywords
like 'gold' from matching unrelated text like 'goldman sachs'.
- Remove industry/sector from generate_keywords output — too broad to use
as correlation keywords without causing noise across all assets.
- Add CONTRIBUTORS.md to Docs/.
- Add tests: generate_keywords (known, unknown, network failure, timeout),
correlate_news substring false-positive regression.
Part of #35 — v0.3 Arbitrary Ticker Support
Codex-Crusader
deleted the
feature/keyword-generation-and-correlation-fi
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #35 - v0.3 Arbitrary Ticker Support