Skip to content

fix(performance): reduce unnecessary reruns and improve dashboard responsiveness #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Codex-Crusader merged 3 commits into from
Apr 14, 2026
+22 −10
Merged

fix(performance): reduce unnecessary reruns and improve dashboard responsiveness #43

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0527958
Refactor auto scan and remove st.rerun calls
shruthikha Apr 13, 2026
fd38051
fix: ensure stale data refresh only occurs on user action via button
shruthikha Apr 13, 2026
b2e5bff
Fix: refresh epoch increment logic in main.py
shruthikha Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 22 additions & 10 deletions dashboard/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,8 +147,15 @@ def _maybe_trigger_scan() -> None:
).start()


_maybe_trigger_scan()

st.sidebar.checkbox(
"Enable auto background scan",
value=True,
key="_enable_auto_scan"
)

if st.session_state.get("_enable_auto_scan", True):
_maybe_trigger_scan()
# Rerun once after a background scan completes so the UI picks up fresh data.
_scan_state = _get_scan_state()
if (
Expand All @@ -159,7 +166,8 @@ def _maybe_trigger_scan() -> None:
st.session_state["_scan_rerun_done"] = True
st.session_state["_scan_refresh_epoch"] = int(st.session_state.get("_scan_refresh_epoch", 0)) + 1
st.rerun()




# Load scan summary once per run — needed for scan status display and main content.
_scan_refresh_epoch = int(st.session_state.get("_scan_refresh_epoch", 0))
Expand Down Expand Up @@ -202,7 +210,7 @@ def _maybe_trigger_scan() -> None:
st.sidebar.caption(f"Last refresh: {dt.datetime.now().strftime('%H:%M:%S')}")

if st.sidebar.button("Refresh Data"):
st.session_state["_scan_refresh_epoch"] = _scan_refresh_epoch + 1
st.session_state["_scan_refresh_epoch"] = st.session_state.get("_scan_refresh_epoch", 0) + 1
st.session_state.pop("_stale_refresh_triggered", None)
st.rerun()

Expand All @@ -220,7 +228,7 @@ def _maybe_trigger_scan() -> None:
if not _scan_state["running"] and _scan_state["lock"].acquire(blocking=False):
_scan_state["last_started"] = time.time()
_scan_state["running"] = True
st.session_state["_scan_refresh_epoch"] = _scan_refresh_epoch + 1
st.session_state["_scan_refresh_epoch"] = st.session_state.get("_scan_refresh_epoch", 0) + 1
threading.Thread(
target=_run_background_scan,
daemon=True,
Expand Down Expand Up @@ -251,10 +259,14 @@ def _maybe_trigger_scan() -> None:
# ── Main panel ─────────────────────────────────────────────────────────────────

_stale = is_data_stale(_summary)
if _stale and not st.session_state.get("_stale_refresh_triggered", False):
st.session_state["_stale_refresh_triggered"] = True
st.session_state["_scan_refresh_epoch"] = _scan_refresh_epoch + 1
if _stale:
st.info("Data is stale. Refresh recommended.")

if st.button("Refresh now"):
st.session_state["_scan_refresh_epoch"] = st.session_state.get("_scan_refresh_epoch", 0) + 1
st.session_state["_stale_refresh_triggered"] = True
st.rerun()

st.markdown(f"# {selected_asset}")
st.caption(f"{selected_category} · `{ticker}` · last 30 days")

Expand Down Expand Up @@ -283,8 +295,8 @@ def _maybe_trigger_scan() -> None:
if not _news_loaded:
st.markdown("### Related News")
if st.button("Load news feed", key="_news_btn"):
st.session_state["_news_for"] = ticker
st.rerun()
st.session_state["_news_for"] = ticker
st.rerun()
st.caption("News is not fetched on startup. Click above to load from 12 RSS feeds.")
else:
articles = cached_news()
Expand Down Expand Up @@ -334,7 +346,7 @@ def _maybe_trigger_scan() -> None:
except Exception as _ctx_exc:
st.warning(
f"Market context analysis failed: {_ctx_exc}",
icon="⚠️",
icon="warning",
)

live_signal = compute_signal_score(
Expand Down
Loading