Skip to content

Fix writability of 1_synth.sdc #10818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hzeller wants to merge 1 commit into from
Closed

Fix writability of 1_synth.sdc #10818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@ archive_override(
patch_strip = 1,
patches = [
"//bazel/bazel-orfs-patches:0035-fix-remove-non-root-overrides-from-MODULE.bazel.patch",
"//bazel/bazel-orfs-patches:0036-fix-sdc-readonly.patch",
],
sha256 = "8325c6755215857a87a84db078d47dfbb2dfcbef70eaf0dd376fe5a7a363cd58",
strip_prefix = "OpenROAD-flow-scripts-" + ORFS_COMMIT,
Expand Down
8 changes: 8 additions & 0 deletions bazel/bazel-orfs-patches/0036-fix-sdc-readonly.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
--- a/flow/scripts/synth_odb.tcl.orig 2026-07-05 16:03:40.847972593 +0200
+++ b/flow/scripts/synth_odb.tcl 2026-07-05 16:03:40.850477641 +0200
@@ -30,4 +30,5 @@
# the user could have dependencies, such as sourcing util.tcl,
# which are read in here and a canonicalized version is written
# out by OpenSTA that has no dependencies.
+catch {exec chmod +w $::env(RESULTS_DIR)/1_synth.sdc}

@gemini-code-assist gemini-code-assist Bot Jul 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using exec chmod spawns an external process, which is less efficient and less portable than using Tcl's built-in file attributes command. Consider using file attributes -permissions u+w instead.

+catch {file attributes $::env(RESULTS_DIR)/1_synth.sdc -permissions u+w}

@hzeller hzeller Jul 5, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just to fix the build, I am leaving this tweak up to @oharboe when he applies the fix upstream.

@maliberty maliberty Jul 5, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any downside to this change

orfs_write_sdc $::env(RESULTS_DIR)/1_synth.sdc
Loading