Make sure an RBE environment sees the full input.#10817
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the openmp dependency version to 21.1.5.bcr.2 and modifies bazel/tcl_encode_or.bzl to transitively include Python runtime files in the action's tools. The review feedback correctly points out that py3_runtime.files can be None in non-hermetic environments, which would cause a Starlark evaluation error, and provides a safe fallback suggestion.
hzeller
force-pushed
the
feature-20260705-rbe-ready
branch
from
538edea to
63e1c87
Compare
Noticed when running in a remote build environment: bazel did not ship everything needed to run the script. Fixed the depset to be comprehensive Similar openmp, but that has already been fixed in bazelbuild/bazel-central-registry#8952 and we just need to fetch the new version. Signed-off-by: Henner Zeller <h.zeller@acm.org>
hzeller
force-pushed
the
feature-20260705-rbe-ready
branch
from
63e1c87 to
1bfacbc
Compare
|
@codex review |
|
Does RBE work for you? It is on my list of things to explore/setup. |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Yes, i am currently setting this up for me, running on my desktop and another older laptop, so that my regular laptop can send that all there without draining battery :) This PR and #10818 seems to make it fully work for me (I use buildbarn for which I made a nix configuration for my machines). |
2 participants
Noticed when running in a remote build environment: bazel did not ship everything needed to run the script. Fixed the depset to be comprehensive
Similar openmp, but that has already been fixed in bazelbuild/bazel-central-registry#8952 and we just need to fetch the new version.