fix(schema): wrap IfcArcIndex/IfcLineIndex indices as IfcPositiveInteger#2042
Open
beachtom wants to merge 1 commit into
Open
fix(schema): wrap IfcArcIndex/IfcLineIndex indices as IfcPositiveInteger#2042beachtom wants to merge 1 commit into
beachtom wants to merge 1 commit into
Conversation
In generateInitialiser and generatePropAssignment, list types whose element type is itself an IFC type (e.g. IfcPositiveInteger) were deserialised using raw x.value (a plain number) instead of wrapping each element in the correct typed constructor. This caused IfcArcIndex and IfcLineIndex to expose Array<number> instead of Array<IfcPositiveInteger> through the TypeScript API, breaking instanceof checks and the .type discriminator field. Fix: detect when a list element type exists in the IFC types registry and emit new SchemaName.TypeName(x.value) instead of x.value. Fixes #1881 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In generateInitialiser and generatePropAssignment, list types whose element type is itself an IFC type (e.g. IfcPositiveInteger) were deserialised using raw x.value (a plain number) instead of wrapping each element in the correct typed constructor.
This caused IfcArcIndex and IfcLineIndex to expose Array instead of Array through the TypeScript API, breaking instanceof checks and the .type discriminator field.
Fix: detect when a list element type exists in the IFC types registry and emit new SchemaName.TypeName(x.value) instead of x.value.
Fixes #1881