Redmine 5 compatible

[jcatrysse]

Add a GEM + small code change to make it work with Redmine 5.
Resolve popup error.

[nekrasovdmitriy]

Thank you, for those who will try to use these commits, do not forget to bundle add render_parent from redmine root.

[jcormier]

Thank you, for those who will try to use these commits, do not forget to bundle add render_parent from redmine root.

Could you expand on this?

[nekrasovdmitriy]

To make these commits work with Redmine 5, you have to install additional Gem "render_parent". I described how to do this from your Redmine installation.

[jcormier]

Ahh is there a file that needs to get updated so that dependency is installed through the normal plugin install process. Without having to explicitly call out render_parent

[jcatrysse]

Ahh is there a file that needs to get updated so that dependency is installed through the normal plugin install process. Without having to explicitly call out render_parent

This shouldn't normally be executed manually. As gem 'render_parent', '~> 0.1.0' has already been added to the init.rb Gemfile file.

Simply running bundle install should do the trick.

[jcormier]

This shouldn't normally be executed manually. As gem 'render_parent', '~> 0.1.0' has already been added to the init.rb file.

Perhaps that's missing, I don't see it in this commit or in the master branch.

[jcatrysse]

This shouldn't normally be executed manually. As gem 'render_parent', '~> 0.1.0' has already been added to the init.rb file.

Perhaps that's missing, I don't see it in this commit or in the master branch.

It's not on the master branch but in Pull Request number #5

Here are the details (two commits): https://github.com/ThatCompany/that_attachments_limit/pull/5/commits

[jcormier]

Okay sorry I see it, it's in Gemfile and not init.rb