Export/Import obj array util #22
Conversation
|
Can you add some testcases similar to the existing tivx_utils_export_ref_for_ipc_xfer tests in test_tiovx/test_tivxMem.c? https://github.com/TexasInstruments/tiovx/blob/main/conformance_tests/test_tiovx/test_tivxMem.c#L1342 |
| * \return VX_SUCCESS on success, else failure | ||
| * | ||
| */ | ||
| vx_status vx_utils_export_ref_for_ipc_xfer_objarray(const vx_reference ref, |
There was a problem hiding this comment.
Can these functions be changed from "vx" to "tivx"?
|
|
||
| ipcMsgHandle->numFd = 0; | ||
| *numMessages = numItems; | ||
| VX_PRINT(VX_ZONE_INFO, "vx_utils_export_ref_for_ipc_xfer_objarray() successfull.\n"); |
There was a problem hiding this comment.
Minor typo "successfull" -> "successful"
| * could be transferred over Linux/QNX IPC mechanism to a remote process. | ||
| * This is just a wrapper for tivx_utils_export_ref_for_ipc_xfer. | ||
| * | ||
| * \param [in] ref A valid openVX reference for an object array of images |
There was a problem hiding this comment.
It's not restricted to contain only images, right? I believe this could describe data objects in general
There was a problem hiding this comment.
correct, comment modified
| /*!< \brief structure containing information about object array | ||
| used when type is set to VX_TYPE_OBJECT_ARRAY */ | ||
| struct { | ||
| /*!< \brief The number of image objects */ |
There was a problem hiding this comment.
This should also describe data objects generally
|
Have you considered a tivx_utils_compare_refs_from_ipc_xfer_objarray function as well? |
|
@brockTI concerning the compare function. If you look at the function's signature for the object array import (tivx_utils_import_ref_from_ipc_xfer_objarray) you need to provide the object array ref_ipc_msg and the an array of ref_ipc_msg for each objects to be imported. @brockTI I added a test to showcase the import and export of the object array |
I did it, you will find two different tests: One with a NULL object and one with a valid one. |
2 participants
Hi,
this PR extends the export / import utility for the IPC to support the object array type.
The export function exposes the meta for the object array itself and each element compositing it.
The import function received two ipc structs, one representing the object array and the other for the different elements of the obj array.
please have a look if you want to take it over,