examples: pru_i2c: wire firmware into top-level build (fixes am261x CI)#147
Merged
pratheesh-ti merged 1 commit intoJun 26, 2026
Conversation
The am261x "Verify all makefiles were built" CI step failed with "makefile never built" for the two pru_i2c PRU firmware makefiles, because nothing in the top-level make recursed into them. - Add examples/pru_i2c/makefile aggregator (modeled on examples/empty), scoped to am261x with an am261x target that builds the pru0/pru1 ti-pru-cgt firmware. Non-am261x devices hit the SUPPORTED_PROCESSORS prebuild check and skip cleanly, so other device builds are unaffected. - Add pru_i2c to examples/makefile SUBDIRS so the top-level make recurses into it. Verified with GNU Make dry-runs: am261x recurses into both firmware leaf makefiles (each producing a .out, satisfying the verify step); am263x prints "does not have a build option" and builds nothing. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #137 — meant to fold directly into that PR's branch (
a0502729_PRU_I2C).The am261x "Verify all makefiles were built" CI step on #137 fails with
makefile never builtfor the two pru_i2c PRU firmware makefiles, because nothing in the top-level make recurses into them.This single commit fixes that:
examples/pru_i2c/makefileaggregator (modeled onexamples/empty), scoped to am261x with an am261x target that builds the pru0/pru1 ti-pru-cgt firmware. Non-am261x devices hit theSUPPORTED_PROCESSORSprebuild check and skip cleanly, so other device builds are unaffected.pru_i2ctoexamples/makefileSUBDIRS so the top-level make recurses into it.Verified with GNU Make dry-runs: am261x recurses into both firmware leaf makefiles (each producing a
.out, satisfying the verify step); am263x prints "does not have a build option" and builds nothing.@achala-ti — feel free to merge this into your branch (or cherry-pick
e18657d8) so #137's CI goes green.🤖 Generated with Claude Code