Allow debug to report multiple invocations#168
Merged
darko-marinov merged 4 commits intoTestingResearchIllinois:masterfrom Aug 27, 2022
kaiyaok2:allow_debug_to_report_all_invocations
Merged
Allow debug to report multiple invocations#168darko-marinov merged 4 commits intoTestingResearchIllinois:masterfrom kaiyaok2:allow_debug_to_report_all_invocations
darko-marinov merged 4 commits intoTestingResearchIllinois:masterfrom
kaiyaok2:allow_debug_to_report_all_invocations
Conversation
august782
reviewed
Aug 9, 2022
august782
reviewed
Aug 9, 2022
Contributor
|
The code looks good enough to me to merge so we can release sooner the next version of NonDex to support Java 9+. |
darko-marinov
approved these changes
Aug 27, 2022
Contributor
darko-marinov
left a comment
darko-marinov
left a comment
There was a problem hiding this comment.
The code looks good enough to me to merge so we can release sooner the next version of NonDex to support Java 9+.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the idea in (#53) to report many invocations from all seeds that can reproduce error.
3 changes are made w.r.t the original PR:
reportDebugInfo(), which subsequently callsfailsWithConfig()can returnnulleven if being run with the same "originally failing" configuration. Then, the listallFailingConfigurationscan containnullentries, which causes NPE when iterating through the list. The solution is to add a null check to avoid NPE thrown bymakeResultString().