Skip to content

Conversation

@Copro
Copy link

@Copro Copro commented Jul 14, 2016

Fix required because if JIRA API change

@fmancardi
Copy link
Contributor

IMHO this fix can be done only if is compatible with older JIRA versions, if not best option is to check for JIRA version and use call specific to each version

@Copro
Copy link
Author

Copro commented Jul 15, 2016

I thought about that and checked also older JIRA API releases. In my option this call has not been working from the beginning (I also created a pull request in the original project which has been inactive since 2013: FayP/JIRA-php#9)
15-Feb-2012 - JIRA API 5.0 : https://docs.atlassian.com/jira/REST/5.0/#id199293 (OK)
21-May-2013 - JIRA API 6.0 : https://docs.atlassian.com/jira/REST/6.0/#id160233 (OK)
29-Jun-2015 - JIRA API 7.0-SNAPSHOT: https://docs.atlassian.com/jira/REST/7.0-SNAPSHOT/#api/2/user-getUser (OK)

--> So there should be no need to check for the JIRA Version - the function getUser was implemented wrong in the first place.

@fmancardi fmancardi merged commit e516836 into TestLinkOpenSourceTRMS:testlink_1_9 Jul 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants