doc(tutorial): made a tutorial for unity developer a better understan…#79
Open
Imitater967 wants to merge 5 commits intoTerasology:developfrom
Open
doc(tutorial): made a tutorial for unity developer a better understan…#79Imitater967 wants to merge 5 commits intoTerasology:developfrom
Imitater967 wants to merge 5 commits intoTerasology:developfrom
Conversation
BenjaminAmos
reviewed
Apr 2, 2024
BenjaminAmos
left a comment
BenjaminAmos
left a comment
There was a problem hiding this comment.
This looks mostly good, although I have some thoughts about particular wording and requests for clarification.
Additional graphics documentation has been sorely needed. Thanks!
Comment on lines
+9
to
+11
| You can regard a node as a "Render Pass" or simply a "Render Feature" in Unity. | ||
| A pass is a rendering stage, a render feature is a customized code you can do in during a stage. | ||
| So a Terasology node is more like a "Render Feature" in Unity. |
There was a problem hiding this comment.
It is a "Render Pass" or a "Render Feature" then? This paragraph is a bit confusing. Are you trying to suggest that a node actually performs aspects of both things?
Contributor
Author
There was a problem hiding this comment.
oh, my misteake, a render feature already included render pass, render feature is like a wrapper for pass. sorry.
| A pass is a rendering stage, a render feature is a customized code you can do in during a stage. | ||
| So a Terasology node is more like a "Render Feature" in Unity. | ||
|
|
||
| Image, there is not rendering stage concept, event the rendering stage itself is a rendering feature. |
There was a problem hiding this comment.
There appear to be a few typos here. Did you mean this?
Suggested change
| Image, there is not rendering stage concept, event the rendering stage itself is a rendering feature. | |
| Imagine that there is no rendering stage concept. That even the rendering stage itself is a rendering feature. |
jdrueckert
reviewed
Apr 3, 2024
|
|
||
| ## Common Issues | ||
|
|
||
| If you wrote a shader, but Terasology doesn't recognize it, you must remember to create a material. |
Member
There was a problem hiding this comment.
Cervator already asked about this: You mean that if Terasology doesn't recognize a shader I wrote, I probably forgot to create a material and have to create one, right?
…ding about the module
jdrueckert
reviewed
Apr 7, 2024
Member
jdrueckert
left a comment
jdrueckert
left a comment
There was a problem hiding this comment.
some more minor typos and wording suggestions
Co-authored-by: jdrueckert <jd.rueckert@googlemail.com>
Co-authored-by: jdrueckert <jd.rueckert@googlemail.com>
Co-authored-by: jdrueckert <jd.rueckert@googlemail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added tutorial for unity developer better unstanding of DAG