Skip to content

fix(daemon): flush identity to disk on shutdown (PILOT-321) #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matthew-pilot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(daemon): flush identity to disk on shutdown (PILOT-321) #206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions pkg/daemon/daemon.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1407,6 +1407,18 @@ func (d *Daemon) doStop() {
// so the daemon.shutting_down event published above flows through
// the bus to the still-subscribed plugin, which drains its
// internal queue on Stop().

// Defense-in-depth: flush identity to disk on shutdown.
// Today all identity mutations persist eagerly (GenerateIdentity
// in startNetworked and RotateKey save synchronously), but a
// future code path that mutates d.identity in-memory without a
// write would lose the change on next start. Writing here ensures
// identity on disk always reflects the shutdown state.
if d.config.IdentityPath != "" {
if err := crypto.SaveIdentity(d.config.IdentityPath, d.identity); err != nil {
slog.Warn("identity flush on shutdown failed", "error", err)
}
}
}

// startManaged detects managed networks this node belongs to and starts engines.
Expand Down
Loading