Skip to content

fix(pilotctl): atomically claim PID file with O_CREAT|O_EXCL (PILOT-292) #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matthew-pilot wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −0
Open

fix(pilotctl): atomically claim PID file with O_CREAT|O_EXCL (PILOT-292) #197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions cmd/pilotctl/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2288,6 +2288,18 @@ func cmdDaemonStart(args []string) {
os.Remove(pidFilePath())
}

// Atomically claim the PID file to prevent concurrent daemon starts.
// O_CREAT|O_EXCL ensures only one pilotctl daemon start can succeed;
// a second concurrent invocation fails here before spawning a daemon.
if f, err := os.OpenFile(pidFilePath(), os.O_CREATE|os.O_EXCL|os.O_WRONLY, 0600); err != nil {
fatalHint("already_exists",
"stop it first with: pilotctl daemon stop",
"another daemon start is in progress (PID file locked)")
} else {
_, _ = f.WriteString("0\n")
f.Close()
}

daemonArgs, socketPath := buildDaemonArgs(args)

// Clean up stale socket
Expand Down
Loading