fix: log warning when tunnel encryption is disabled (PILOT-256)#180
fix: log warning when tunnel encryption is disabled (PILOT-256)#180matthew-pilot wants to merge 1 commit into
Conversation
|
🤖 Hank — CI status Classification: The build/test failure is a genuine code defect: @matthew-pilot — fix or comment. Auto-classified at 2026-06-02T12:15:43Z. Re-runs on next push or check completion. |
🦾 Matthew PR Check — #180 PILOT-256Status
VerdictCLEAN — single-file, 2-line log addition. CI failures pre-existing (Go macos + Arch gates fail broadly across pilotprotocol). Safe to merge. What changedAdds |
🦾 Matthew Explains — #180 PILOT-256What this doesAdds a single WhyWhen Change// pkg/daemon/daemon.go — daemon.Start()
if d.config.Encrypt {
if err := d.tunnels.EnableEncryption(); err != nil {
return fmt.Errorf("tunnel encryption: %w", err)
}
} else {
slog.Warn("tunnel encryption is disabled — all connections will send plaintext") // ← NEW
}Risk assessmentNegligible. 2-line log addition, no control flow change, no new dependencies, tests pass ( |
🦾 Matthew PR Status — #180Overview
TicketsNone detected in title Labelsmatthew-fix Files Changed
PR DescriptionNext Actions
🦾 Auto-generated status check by matthew-pr-worker |
PR #155 extracted pkg/registry to pilot-protocol/rendezvous and pkg/secure to pilot-protocol/common, but the architecture-gates workflow still ran 'go test ./pkg/registry/... ./pkg/secure', which now fails with 'no such file or directory' on every PR. Replace with ./pkg/daemon/... — the daemon-side lock graph (Store.mu, ReplayMu, SalvageMu, tm.mu) is what this gate is actually meant to cover. The extracted layers' lock-graph coverage now runs from their own sibling repos. Verified locally on ubuntu equivalent: arch-gates command 'go test -race -timeout 5m ./pkg/daemon/...' completes without the missing-directory errors. Unblocks PRs #177, #178, #179, #180. Co-authored-by: Teodor Calin <teodor@vulturelabs.io>
5831b73 to
02fc0a6
Compare
When config.Encrypt is false, the daemon silently ran without encryption — every connection sent plaintext. Add slog.Warn so a misconfigured or tampered config is flagged at startup.
02fc0a6 to
775508d
Compare
|
📊 Status (PILOT-256) PR is open, mergeable but CI is blocked (Architecture gates ❌, Go macos ❌). Go ubuntu ✅, CodeQL ✅, Snyk ✅. Canary running (run 26700794184, re-dispatched 2026-05-31T02:13Z). Jira: PILOT-256 in QA/IN-REVIEW. Last activity: 2026-05-31T17:07Z (recent). 🤖 matthew-pilot worker tick |
🤖 PR Clarification — Review Requested#180: fix: log warning when tunnel encryption is disabled (PILOT-256) SummaryWhatWhen FixAdd if d.config.Encrypt {
if err := d.tunnels.EnableEncryption(); err != nil {
return fmt.Errorf("tunnel encryption: %w", err)
}
} else {
slog.Warn("tunnel encryption is disabled — all connections will send plaintext")
}##... Changes+2/−0 across 1 file(s):
CI StatusCodeQL ✅ | Architecture gates ❌ | Analyze Go ✅ | dispatch ✅ | Go (macos-latest) ❌ | Go (ubuntu-latest) ✅ Labels
👋 @TeoSlayer — this PR is ready for your review. matthew-pr-worker • 2026-06-01T12:55:00Z |
|
@TeoSlayer 🔔 Reminder — PR #180 needs attention (PILOT-256) This PR has been open for ~4 days with label PR: fix: log warning when tunnel encryption is disabled Please review when available. |
|
📊 PR Status — #180 (PILOT-256)
|
🤖 PR Clarification — #180 (PILOT-256)PR: fix: log warning when tunnel encryption is disabled What this PR doesAdds a single Current Blockers
What's needed@TeoSlayer — this PR needs operator attention:
Previous pings
|
|
@TeoSlayer 🔔 Reminder #3 — PR #180 needs triage (PILOT-256) Status: OPEN · MERGEABLE (behind) · Previous pings: Jun 1 clarify, Jun 2 12:46/13:15/13:21 UTC. No operator response yet. Actions needed:
🦾 matthew-pr-worker · 2026-06-02T17:41:47Z |
|
📊 PR Status — #180 (PILOT-256) · updated 2026-06-02T17:45Z
🦾 matthew-pr-worker |
What
When
config.Encryptis false, the daemon silently runs without tunnel encryption — every connection sends plaintext with zero indication. A misconfigured or tamperedconfig.jsonwith"encrypt": falseproduces no log warning.Fix
Add
slog.Warnwhen encryption is disabled so operators can immediately spot the issue at startup:Verification
go build ./...✅go vet ./pkg/daemon/✅go test -short -count=1 ./pkg/daemon/✅ (20.9s, all pass)pkg/daemon/daemon.go), +3 linesTicket
🔗 https://vulturelabs.atlassian.net/browse/PILOT-256