Audio Service sample#316
Open
ianffcs wants to merge 3 commits intoTensegritics:mainfrom
Open
Conversation
261af05 to
2a1d419
Compare
2a1d419 to
6928429
Compare
Contributor
|
some remarks:
in a I've not finished the work, I am quite busy but it's a start |
Contributor
|
Hey @ianffcs thank you for this work. However I think it's better for samples to focus on one thing at a time so that the reader doesn't have to grok several concepts/libs at once. Here several unrelated packages are used. Would it be possible to reduce the scope? |
Contributor
Author
|
I can't think on how I can reduce the scope, because it's a sample about having an audio player that plays on background. This is the minimal example that I've found around for doing this. This is very useful for anyone that wants to implement this audio-background feature in any app. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audio Service sample reflecting this example:
https://github.com/ryanheise/audio_service/blob/minor/audio_service/example/lib/example_android13.dart