Don't send page view events when telemetry is disabled#256
Open
takluyver wants to merge 2 commits intoTenderOwl:masterfrom
Open
Don't send page view events when telemetry is disabled#256takluyver wants to merge 2 commits intoTenderOwl:masterfrom
takluyver wants to merge 2 commits intoTenderOwl:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's somewhat unusual for open source projects to have on by default telemetry. I think that's up to you, but if I disable telemetry in the settings, I expect that to stop all telemetry. Page view events (
telemetry.capture_page_view()) are currently sent regardless of the telemetry setting.Going a step further, I've made it set up the posthog client only if telemetry is enabled. This is meant to prevent similar mistakes where the setting is ignored, including accidentally sending telemetry at startup before the setting value has been applied.