fix: handle unrecognized language codes gracefully#236
Open
gwuen wants to merge 1 commit intoTenderOwl:masterfrom
Open
fix: handle unrecognized language codes gracefully#236gwuen wants to merge 1 commit intoTenderOwl:masterfrom
gwuen wants to merge 1 commit intoTenderOwl:masterfrom
Conversation
Previously, the language list would fail to load if the tessdata directory contained any files with unrecognized language codes, as sorting would raise an exception for unknown languages. The check for valid codes, which was already implemented in `get_downloaded_languages()`, has been moved to be done earlier in `get_downloaded_codes()` to prevent these errors. Now, any unrecognized codes are ignored, with a warning message logged to the console.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the language list would fail to load if the tessdata directory contained any files with unrecognized language codes, as sorting would raise an exception for unknown languages.
The check for valid codes, which was already implemented in
get_downloaded_languages(), has been moved to be done earlier inget_downloaded_codes()to prevent these errors. Now, any unrecognized codes are ignored, with a warning message logged to the console.