fix(settings): handle preferences fetch failure instead of hanging#71
Open
Chzhqv wants to merge 1 commit into
Open
fix(settings): handle preferences fetch failure instead of hanging#71Chzhqv wants to merge 1 commit into
Chzhqv wants to merge 1 commit into
Conversation
The /api/user/preferences fetch in useEffect only chained .then(), with setLoading(false) called inside it. A rejected fetch (network drop, or a 5xx whose body throws in .json()) left loading stuck at true forever, so the page never left the Skeleton. Add .catch to surface an error toast and .finally to always clear loading. Added a regression test (confirmed it fails without the fix, passes with it) since this bug is easy to silently reintroduce. Fixes TemaDeveloper#20
|
Someone is attempting to deploy a commit to the Artemii's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useEffectfetching/api/user/preferencesonly chained.then(), withsetLoading(false)called inside it. A rejected fetch (network drop, or a 5xx whose body throws in.json()) leftloadingstuck attrueforever, so the page never left the Skeleton..catchto surface an error toast and.finallyto always clear loading.Test plan
settings/__tests__/page.test.tsx) mocking a rejected preferences fetch — confirmed it fails without the fix (unhandled rejection) and passes with itpnpm lint,tsc --noEmit, fullvitest run(557/557) all passFixes #20