perf(habits): batch habit log queries instead of N+1 per-day lookups#69
Open
Chzhqv wants to merge 1 commit into
Open
perf(habits): batch habit log queries instead of N+1 per-day lookups#69Chzhqv wants to merge 1 commit into
Chzhqv wants to merge 1 commit into
Conversation
GET /api/habits ran a today-log query per habit plus up to 365 individual queries per habit for streak calculation (10 habits could mean 3650+ DB round-trips). Batch-fetch all logs in the lookback window with a single habitId $in query and compute completedToday/ streak in memory instead. Fixes TemaDeveloper#6
|
Someone is attempting to deploy a commit to the Artemii's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /api/habitsran a today-log query per habit plus up to 365 individual per-day queries per habit for streak calculation (10 habits could mean 3650+ DB round-trips).habitId: {$in}query and computecompletedToday/streak in memory instead.Test plan
date-fnshelpers the route uses, to avoid timezone drift), confirmed the API still returnsstreak: 4exactly as before — gap correctly breaks the streak, isolated day correctly excludedhabitlogsper call, regardless of habit countpnpm lint,tsc --noEmit, fullvitest run(556/556) all passFixes #6