fix(habits): handle concurrent toggle race in habit log create#68
Merged
TemaDeveloper merged 1 commit intoJul 7, 2026
Merged
Conversation
Two concurrent toggle-on requests for the same habit+day could both observe "no existing log" and both call HabitLog.create(), tripping the unique habitId+date index and crashing with an unhandled 500 on the losing request. Catch the duplicate-key error and report toggled:true instead, since a log exists either way. Fixes TemaDeveloper#1
|
Someone is attempting to deploy a commit to the Artemii's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HabitLog.create(), tripping the uniquehabitId+dateindex and crashing with an unhandled 500 on the losing request.toggled: trueinstead, since a log exists either way once the race resolves.Test plan
&/wait) against a running dev server + real MongoDB — got201+200, no 500, confirmed exactly oneHabitLogdocument afterward (no duplicate)pnpm lint,tsc --noEmit, fullvitest run(556/556) all passFixes #1