security: scrub proprietary references from public repo + harden internal-refs guard#115
Merged
Merged
Conversation
…ternal-refs guard One doc under packages/adapters/duffel referenced the proprietary commercial layer (product name, a payment vendor, and a supplier certification blocker) — business detail that must not live in the public OTAIP repo. Rewrote it to OTAIP-only forward framing: the Duffel adapter's product-coverage roadmap (Flights done; Payments/Stays/Cars TODO), with no downstream-consumer references. Also extended scripts/check-no-internal-refs.sh to block the two proprietary product names going forward — the existing CI guard's pattern list did not include them, which is why this slipped through. Guard passes; no such references remain in tracked files. https://claude.ai/code/session_01TwDq6fWRtNtPqxzYm4fshB
…-52qc) The pnpm audit --audit-level=high CI gate flagged a High advisory in hono (CORS wildcard-with-credentials), pulled via @modelcontextprotocol/sdk in packages/connect. The existing override floor (>=4.12.16) predates the patched version (>=4.12.25). Bump it; audit --audit-level=high now passes (resolves to hono 4.12.26). https://claude.ai/code/session_01TwDq6fWRtNtPqxzYm4fshB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A doc under
packages/adapters/duffelreferenced the proprietary commercial layer — a product name, a payment vendor, and a supplier certification blocker. That business detail must not live in the public OTAIP repo. The existingcheck-no-internal-refs.shCI guard didn't catch it because its pattern list didn't include those product names.What
packages/adapters/duffel/PARITY_ROADMAP.mdto OTAIP-only, forward-framed content: the Duffel adapter's product-coverage roadmap (Flights ✅; Payments/Stays/Cars TODO). No downstream-consumer references, no vendor/operational detail.scripts/check-no-internal-refs.shto block those two proprietary product names (case-insensitive) going forward — so this class of leak can't merge again.Verified
bash scripts/check-no-internal-refs.sh→ clean.git grep→ no proprietary references remain in any tracked file.Notes
https://claude.ai/code/session_01TwDq6fWRtNtPqxzYm4fshB
Generated by Claude Code