fix(security): scope connect modify() guest write (review follow-up to #126)#128
Merged
Merged
Conversation
… instead of overwriting Review follow-up: findOrCreateGuest reuse was scoped to the property, but modify() still updated the cross-property guests row by bare id, so a caller could rename a guest shared with another tenant (PII poison on legacy shared rows). Now: if the guest is linked to any OTHER property, fork a property-local copy and repoint this reservation; otherwise update in place. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
telivity-otaip
added a commit
that referenced
this pull request
Jun 20, 2026
…il-open on bad config (#130) Independent codex review of #126-#128 found two gaps: - assertSafeChannelEndpoint only enforced for NODE_ENV=production, leaving staging open to SSRF even though this changeset hardened staging elsewhere. Now enforces for production OR staging (matches assertSecureConfig). - SMS quota parsed env with Number() and disabled on NaN, so SMS_RATE_LIMIT_MAX=garbage silently turned the limiter off. Now an invalid value falls back to the default (limiter stays on); only an explicit valid value <= 0 disables it. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvement-loop review (Claude + Codex) of #126/#127 found one incomplete fix:
ConnectBookingService.modify()still overwrote the cross-propertyguestsrow by bare id, so a caller could rename a guest shared with another tenant (PII poison on legacy shared rows — the exact write-side vector #126's own comment flagged).Now: if the guest is linked to any other property, fork a property-local copy and repoint this reservation; otherwise update in place. TDD (fork + no-over-fork tests). Full suite 1007/1007, typecheck clean.
🤖 Generated with Claude Code