Skip to content

Fix crash: disable in-chat SwiftUI translation service (fatal trap in Translation framework internals) #2219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ankuper wants to merge 1 commit into
base: master
Choose a base branch
from
+16 −6
Open

Fix crash: disable in-chat SwiftUI translation service (fatal trap in Translation framework internals) #2219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions submodules/TelegramUI/Sources/Chat/ChatControllerLoadDisplayNode.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -683,12 +683,22 @@ extension ChatControllerImpl {
}
}

if #available(iOS 18.0, *) {
if engineExperimentalInternalTranslationService == nil, let hostView = self.context.sharedContext.mainWindow?.hostView {
let translationService = ExperimentalInternalTranslationServiceImpl(view: hostView.containerView)
engineExperimentalInternalTranslationService = translationService
}
}
// Disabled: ExperimentalInternalTranslationServiceImpl.init constructs a
// UIHostingController(rootView: TranslationViewImpl(...)) that fatal-traps
// inside SwiftUI/Translation-framework internals on device (SIGABRT, no
// application-code frames at the trap site — confirmed on iOS 26.5,
// reproducible on the first chat opened per app session). A trap inside
// Apple's own framework code cannot be guarded or caught from Swift, so
// the only available mitigation is not calling into it. Re-enable once
// the underlying SwiftUI + .translationTask interop bug is understood
// or fixed by an OS update.
//
// if #available(iOS 18.0, *) {
// if engineExperimentalInternalTranslationService == nil, let hostView = self.context.sharedContext.mainWindow?.hostView {
// let translationService = ExperimentalInternalTranslationServiceImpl(view: hostView.containerView)
// engineExperimentalInternalTranslationService = translationService
// }
// }

self.displayNode = ChatControllerNode(context: self.context, chatLocation: self.chatLocation, chatLocationContextHolder: self.chatLocationContextHolder, subject: self.subject, controllerInteraction: self.controllerInteraction!, chatPresentationInterfaceState: self.presentationInterfaceState, automaticMediaDownloadSettings: self.automaticMediaDownloadSettings, navigationBar: self.navigationBar, statusBar: self.statusBar, backgroundNode: self.chatBackgroundNode, controller: self)

Expand Down