Skip to content

Method Impl. #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ted-Jin-Lab merged 3 commits into from
Dec 23, 2025
Merged

Method Impl. #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
95c04fc
feat: add Method impl feature and the default value fix.
Ted-Jin-Lab Dec 23, 2025
7d54658
Merge branch 'main' into development
Ted-Jin-Lab Dec 23, 2025
94d3340
🔖 2025.12.23.1 Released!
Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<Project>
<PropertyGroup>
<Version>2025.12.23.0</Version>
<Version>2025.12.23.1</Version>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<LangVersion>preview</LangVersion>
Expand Down
23 changes: 21 additions & 2 deletions src/libraries/TedToolkit.RoslynHelper/Extensions/SyntaxExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using Microsoft.CodeAnalysis;
using System.Runtime.CompilerServices;
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.CSharp;
using Microsoft.CodeAnalysis.CSharp.Syntax;
using TedToolkit.RoslynHelper.Names;
Expand Down Expand Up @@ -133,7 +134,25 @@ public static AttributeListSyntax GeneratedCodeAttribute(Type generator)
/// <returns></returns>
public static AttributeSyntax NonUserCodeAttribute()
{
return Attribute(IdentifierName("global::System.Diagnostics.DebuggerNonUserCode"));
return Attribute(IdentifierName("global::System.Diagnostics.DebuggerNonUserCodeAttribute"));
}

/// <summary>
/// Method Impl Attribute
/// </summary>
/// <param name="methodImplOptions"></param>
/// <returns></returns>
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static AttributeSyntax MethodImplAttribute(MethodImplOptions methodImplOptions)
{
return Attribute(IdentifierName("global::System.Runtime.CompilerServices.MethodImplAttribute"))
.WithArgumentList(AttributeArgumentList(
[
AttributeArgument(MemberAccessExpression(
SyntaxKind.SimpleMemberAccessExpression,
IdentifierName("global::System.Runtime.CompilerServices.MethodImplOptions"),
IdentifierName("AggressiveInlining")))
]));
}

/// <summary>
Expand Down
4 changes: 1 addition & 3 deletions src/libraries/TedToolkit.RoslynHelper/Names/ParameterName.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,7 @@ public ParameterSyntax ParameterSyntax

if (value == null)
{
return type.IsValueType
? LiteralExpression(SyntaxKind.DefaultLiteralExpression)
: LiteralExpression(SyntaxKind.NullLiteralExpression);
return LiteralExpression(SyntaxKind.DefaultLiteralExpression);
}

switch (type.SpecialType)
Expand Down