Update haproxy.cfg to silence warning about 0 for server timeout#164
Update haproxy.cfg to silence warning about 0 for server timeout#164esabol wants to merge 1 commit intoTecnativa:masterfrom
Conversation
This partially addresses issue Tecnativa#123 by changing the configured value of the server timeout for the docker-events backend from 0 to 30s. It silences the following warning message: [WARNING] While not properly invalid, you will certainly encounter various problems with such a configuration. To fix this, please ensure that all following timeouts are set to a non-zero value: 'client', 'connect', 'server'.
pedrobaeza
left a comment
There was a problem hiding this comment.
Isn't the amount very high?
|
Maybe a better timeout would be something like 5 or 10 seconds |
|
@pedrobaeza @josep-tecnativa : I'm happy to use whichever number you prefer. 30 is just what was suggested in issue #123. |
|
It's been pointed out that the 0 value comes from PR #98. Maybe this shouldn't be changed? |
|
Thanks for sharing this PR. I’ve been investigating a bit, and the /events endpoint is a long-lived streaming connection. Docker keeps sending data as long as the client is listening, so the connection doesn’t really hang. That’s why a timeout is not needed here — setting one would only risk breaking valid event streams. I see that the 0 value comes from PR #98 I'm closing this PR. Thank you anyway. |
Changing the timeout definitely does eliminate the warning message. I tested that. That said, I agree that it shouldn't be changed just to eliminate the warning message for the reason given in PR #98. |
This PR partially addresses issue #123 by changing the configured value of the server timeout for the docker-events backend from 0 to 30s. It silences the following warning message:
[WARNING] While not properly invalid, you will certainly encounter various problems with such a configuration. To fix this, please ensure that all following timeouts are set to a non-zero value: 'client', 'connect', 'server'.